I'm warming to this change/coming to terms with its inevitability.
Some non-blocking comments to consider.
* Please reconsider the 4x growth factor. It's caused by the resizing
heuristic
which is an unusual feature.
* Currently you can have a resize during a rehash. You should either be
sure
the tests cover this happening or change the resizing heuristic so it can't
happen.
* Those methods that require the mutex should assert that they have it.
This
includes Heap::IterateStrongRoots
* Release mode asserts that are not security relevant bloat the code.
https://codereview.chromium.org/1105693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
