Thanks for the review. I rewrote the implementation and tests. Can you take
a
look?
https://codereview.chromium.org/1098663002/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/1098663002/diff/1/src/promise.js#newcode154
src/promise.js:154: IsUnforgedPromise = function IsUnforgedPromise(x) {
On 2015/04/17 14:32:06, arv wrote:
Does this need to be exported?
Deleted.
https://codereview.chromium.org/1098663002/diff/1/src/promise.js#newcode159
src/promise.js:159: return x.then === PromiseThen;
On 2015/04/17 14:32:06, arv wrote:
Which section of the ES6 spec defines this? I cannot find anything
about this?
Deleted.
https://codereview.chromium.org/1098663002/diff/1/src/promise.js#newcode159
src/promise.js:159: return x.then === PromiseThen;
On 2015/04/17 14:32:06, arv wrote:
This needs a test to ensure that the getter is invoked at the right
time and the
correct amount of times.
Deleted.
https://codereview.chromium.org/1098663002/diff/1/test/webkit/fast/js/Promise-coerce.js
File test/webkit/fast/js/Promise-coerce.js (right):
https://codereview.chromium.org/1098663002/diff/1/test/webkit/fast/js/Promise-coerce.js#newcode1
test/webkit/fast/js/Promise-coerce.js:1: // Copyright 2015 the V8
project authors. All rights reserved.
On 2015/04/17 14:32:06, arv wrote:
test/webkit/ is for tests imported from webkit. New tests should be
written in
test/mjsunit and in this case test/mjsunit/es6/
Done.
https://codereview.chromium.org/1098663002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
