LGTM
http://codereview.chromium.org/504026/diff/3001/3010 File src/globals.h (right): http://codereview.chromium.org/504026/diff/3001/3010#newcode186 src/globals.h:186: static const int kPageSizeBits = 13; Get rid of static? Add a bit more information to the comment? http://codereview.chromium.org/504026/diff/3001/3010#newcode465 src/globals.h:465: // POINTER_SIZE_ALIGN returns the value aligned as a pointer. POINTER -> MAP pointer -> map http://codereview.chromium.org/504026/diff/3001/3002 File src/heap.cc (right): http://codereview.chromium.org/504026/diff/3001/3002#newcode1146 src/heap.cc:1146: // If the map bject is aligned fill the padding area with Smi 0 objects. bject -> object http://codereview.chromium.org/504026/diff/3001/3008 File src/objects-inl.h (right): http://codereview.chromium.org/504026/diff/3001/3008#newcode979 src/objects-inl.h:979: << kMapAlignmentBits); I would move the << to the previous line. http://codereview.chromium.org/504026/diff/3001/3011 File test/mjsunit/regress/regress-524.js (right): http://codereview.chromium.org/504026/diff/3001/3011#newcode30 test/mjsunit/regress/regress-524.js:30: var i = 500000 Does this run fast enough in debug mode with extra checking that it will not cause timeouts? http://codereview.chromium.org/504026 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
