http://codereview.chromium.org/504026/diff/6001/6004 File src/spaces.h (left):
http://codereview.chromium.org/504026/diff/6001/6004#oldcode1744 src/spaces.h:1744: static const int kMaxMapPageIndex = (1 << MapWord::kMapPageIndexBits) - 1; On 2009/12/16 16:26:30, antonm wrote: > BTW, do I miss something or this constant should be increased to be something > like (1 << (MapWord::kMapPageIndexBits + kMapAlignmentBits - > kObjectAlignmentBits))? > If yes, could you merge them to get rid of duplication? This is correct, as we need one entry for each possible page of map space. What is wrong however is the calculation of kMaxMapSpaceSize which should be static const int kMaxMapSpaceSize = (1 << (MapWord::kMapPageIndexBits)) * Page::kPageSize; Thanks for spotting this inconsistency. http://codereview.chromium.org/504026 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
