http://codereview.chromium.org/504026/diff/3001/3010 File src/globals.h (right):
http://codereview.chromium.org/504026/diff/3001/3010#newcode186 src/globals.h:186: static const int kPageSizeBits = 13; On 2009/12/16 14:19:16, Mads Ager wrote: > Get rid of static? Add a bit more information to the comment? Done. http://codereview.chromium.org/504026/diff/3001/3010#newcode465 src/globals.h:465: // POINTER_SIZE_ALIGN returns the value aligned as a pointer. On 2009/12/16 14:19:16, Mads Ager wrote: > POINTER -> MAP > pointer -> map Done. http://codereview.chromium.org/504026/diff/3001/3002 File src/heap.cc (right): http://codereview.chromium.org/504026/diff/3001/3002#newcode1146 src/heap.cc:1146: // If the map bject is aligned fill the padding area with Smi 0 objects. On 2009/12/16 14:08:43, antonm wrote: > nit: <o>bject Done. http://codereview.chromium.org/504026/diff/3001/3002#newcode1146 src/heap.cc:1146: // If the map bject is aligned fill the padding area with Smi 0 objects. On 2009/12/16 14:19:16, Mads Ager wrote: > bject -> object Done. http://codereview.chromium.org/504026/diff/3001/3008 File src/objects-inl.h (right): http://codereview.chromium.org/504026/diff/3001/3008#newcode979 src/objects-inl.h:979: << kMapAlignmentBits); On 2009/12/16 14:19:16, Mads Ager wrote: > I would move the << to the previous line. Done. http://codereview.chromium.org/504026/diff/3001/3005 File src/objects.h (right): http://codereview.chromium.org/504026/diff/3001/3005#newcode902 src/objects.h:902: // | | kMapPageIndexBits On 2009/12/16 14:08:43, antonm wrote: > may you also update (or just remove and add a reference) text in mark-compact.cc > (around ln. 834) and in spaces.h (ln. 109)? Thanks for spotting this redundancy. Replaced the other comments with a reference. http://codereview.chromium.org/504026/diff/3001/3011 File test/mjsunit/regress/regress-524.js (right): http://codereview.chromium.org/504026/diff/3001/3011#newcode30 test/mjsunit/regress/regress-524.js:30: var i = 500000 On 2009/12/16 14:19:16, Mads Ager wrote: > Does this run fast enough in debug mode with extra checking that it will not > cause timeouts? It runs in ~25s in debug mode on my machine (~1s in release mode). I will just skip it debug mode (if I can get the mjsunit.status syntax correct). http://codereview.chromium.org/504026 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
