On 2015/05/08 19:17:27, Dmitry Lomov (chromium) wrote:
On 2015/05/08 19:09:49, arv wrote:
> Looks like a good approach.
>
> Some high level comments
>
> - Use macro for visitor
> - Can you use a non inner class and provide an .h file for
PatternMatcher?
> Parser.h is already huge.
This means that PatternMatcher has to be a friend class of Parser. Do you
think
it is preferable to inner class?
I'll let you make the call since you have more C++ experience than me.
https://codereview.chromium.org/1130623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
