https://codereview.chromium.org/1130623004/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1130623004/diff/20001/src/parser.cc#newcode2376
src/parser.cc:2376: decl.nvars = &nvars;
On 2015/05/11 12:52:57, Dmitry Lomov (chromium) wrote:
On 2015/05/11 11:49:33, rossberg wrote:
> Why not move nvars itself to decl, instead of a pointer?
I want to keep decl_ const in PatternRewriter.
Hm, I see. In that case I'd rather pass the pointer as a separate
argument to either the PatternRewriter constructor or to
DeclareAndInitializeVariables -- it's an out-argument, whereas decl is
an in-argument; having it with the function would make clearer when it
actually gets modified.
https://codereview.chromium.org/1130623004/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1130623004/diff/60001/src/parser.cc#newcode2418
src/parser.cc:2418: decl.initialization_scope =
Is there a reason why this can't be local to the rewriter? E.g. where
you moved the comment? (In either case, the comment should be in the
same place where this code is.)
https://codereview.chromium.org/1130623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
