PTAL
https://codereview.chromium.org/1130623004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1130623004/diff/1/src/parser.cc#newcode2496
src/parser.cc:2496: // statements).
On 2015/05/08 19:09:48, arv wrote:
I'm not sure what this means?
This comment is stale, the correct place for it is in
PatternMatcher::VisitVariableProxy. Deleted this one and clarified the
other one a bit, let me know if it helps.
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc
File src/pattern-matcher.cc (right):
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc#newcode146
src/pattern-matcher.cc:146: //
stest-parsing/InitializedDeclarationsInStrictForOfError tart context for
On 2015/05/08 19:09:49, arv wrote:
typo
Done.
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc#newcode151
src/pattern-matcher.cc:151: DCHECK(proxy != NULL);
On 2015/05/08 19:09:49, arv wrote:
DCHECK_NOT_NULL
Done.
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc#newcode190
src/pattern-matcher.cc:190: for (auto i = properties->begin(); i !=
properties->end(); i++) {
On 2015/05/08 19:09:49, arv wrote:
Can we do?
for (auto property : properties) {
Done.
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc#newcode196
src/pattern-matcher.cc:196: property->key(), RelocInfo::kNoPosition));
On 2015/05/08 19:09:49, arv wrote:
TODO(dslomov): Computed property names
Done.
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc#newcode207
src/pattern-matcher.cc:207: void
Parser::PatternMatcher::VisitProperty(Property* node) { UNREACHABLE(); }
On 2015/05/08 19:09:49, arv wrote:
This is only unreachable in binding patterns:
var o = {x: 1};
({y: o.x} = {y: 2});
assert(o.x === 2);
I am not dealing with assignment patterns yet. As the code is now, this
is unreachable.
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc#newcode320
src/pattern-matcher.cc:320: void
Parser::PatternMatcher::VisitDoWhileStatement(DoWhileStatement* node) {
On 2015/05/08 19:09:49, arv wrote:
Maybe a macro for all of these?
Done.
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc#newcode341
src/pattern-matcher.cc:341: void
Parser::PatternMatcher::VisitAssignment(Assignment* node) {
On 2015/05/08 19:09:49, arv wrote:
TODO(dslomov): Implement
var {x: y = 42} = {};
assert(y === 42);
Done.
https://codereview.chromium.org/1130623004/diff/1/src/pattern-matcher.cc#newcode356
src/pattern-matcher.cc:356: void
Parser::PatternMatcher::VisitSpread(Spread* node) { UNREACHABLE(); }
On 2015/05/08 19:09:48, arv wrote:
TODO(dslomov): Implement
var [...xs] = []
Done.
https://codereview.chromium.org/1130623004/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1130623004/diff/1/test/mjsunit/harmony/destructuring.js#newcode8
test/mjsunit/harmony/destructuring.js:8: var { x : x, y : y } = { x : 1,
y : 2 };
On 2015/05/08 19:09:49, arv wrote:
Also:
var {z} = {z: 3};
Should work for free since the parser desugars it before it gets to
the
destructuring.
Done.
https://codereview.chromium.org/1130623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
