https://codereview.chromium.org/1127063003/diff/60001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1127063003/diff/60001/src/preparser.h#newcode3492
src/preparser.h:3492: if (initializer && allow_harmony_optional_params()
&& Check(Token::ASSIGN)) {
On 2015/05/11 14:34:57, caitp wrote:
On 2015/05/11 14:10:54, arv wrote:
> This looks strange. Why are we checking initializer here?

below, *initializer is assigned, and we probably don't want to do that
if
`initializer` is null (which, at the moment, it is for arrow function
parsing)
--- that's kind of a temporary thing though

What initializer are you passing in before the initializer has been
parsed? I guess you are using Empty for the preparser.

Can you add a comment/todo?

https://codereview.chromium.org/1127063003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to