Thanks
https://codereview.chromium.org/1127063003/diff/100001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1127063003/diff/100001/src/parser.cc#newcode4301
src/parser.cc:4301: body->AddAll(*inner_body, zone());
On 2015/05/12 14:04:53, rossberg wrote:
Shouldn't this create a block statement instead?
Is this for the extra bailout id? I have mostly been thinking about
scoping, so I'm not sure what effect wrapping it in a block statement
has
https://codereview.chromium.org/1127063003/diff/100001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/1127063003/diff/100001/src/scopes.cc#newcode513
src/scopes.cc:513: void Scope::ShadowParametersForExpressions() {
On 2015/05/12 14:04:53, rossberg wrote:
Instead of spreading this out into a different function, can't we do
that during
desugaring, right before invoking re-Declare on the respective
variable in
DesugarInitializedPArameters?
well the scope VariableMap is private, so it's hard for the parser to do
itself --- do you mean just get rid of the parser version of the
function?
https://codereview.chromium.org/1127063003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
