On 2015/05/12 07:32:11, wingo wrote:
On 2015/05/11 16:58:19, caitp wrote:
> The preparser logs locations to be lazily parsed, we then parse (lazily)
with
> the full parser, with a really weird (and incorrect) scope tree, at
which
point
> ParseFormalParameterList is used on a scope which is not a function
scope.
> That's what I'm talking about when I'm saying lazy parsing.
If the full parse is running with the wrong scope tree, then that's a bug.
Could it simply be that the scope is not made current? That's probably
it.
I'll see what I can do this morning.
Humm, it's not quite that simple. Really the arguments should be parsed
with
the FunctionState of the function in question, so that the initializers can
get
the right e.g. materialized literal indexes. I'm going to punt on this for
now
as "super" in arrow functions probably has higher priority.
Given that in the future "scope_" should be the same as the "scope" passed
to
ParseFormalParameterList(), why not just change the DCHECK to assert
on "scope"
and not "scope_", and add a TODO?
https://codereview.chromium.org/1127063003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
