https://codereview.chromium.org/1156573002/diff/40001/src/messages.h
File src/messages.h (right):
https://codereview.chromium.org/1156573002/diff/40001/src/messages.h#newcode229
src/messages.h:229: T(StrongDeleteProperty,
\
On 2015/05/22 11:34:50, rossberg wrote:
Perhaps we should stylise strong object error messages consistently.
E.g. always
always formulating them akin to
"On strong object %, property % cannot be deleted"
or something.
Done.
https://codereview.chromium.org/1156573002/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1156573002/diff/40001/src/objects.cc#newcode5519
src/objects.cc:5519: THROW_NEW_ERROR(
On 2015/05/22 11:34:50, rossberg wrote:
Why do we need to throw here? Returning false should already cause an
exception
if invoked in strict mode.
Discussed offline, throw is needed but is in wrong place.
https://codereview.chromium.org/1156573002/diff/40001/src/objects.cc#newcode5542
src/objects.cc:5542: THROW_NEW_ERROR(
On 2015/05/22 11:34:50, rossberg wrote:
Same here.
See above.
https://codereview.chromium.org/1156573002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1156573002/diff/40001/test/cctest/test-api.cc#newcode21111
test/cctest/test-api.cc:21111: TEST(StrongModeObjectDelete) {
On 2015/05/22 11:34:50, rossberg wrote:
Nit: StrongObjectDelete (especially since the delete happens outside
the mode)
Done.
https://codereview.chromium.org/1156573002/diff/40001/test/mjsunit/strong/object-delete.js
File test/mjsunit/strong/object-delete.js (right):
https://codereview.chromium.org/1156573002/diff/40001/test/mjsunit/strong/object-delete.js#newcode21
test/mjsunit/strong/object-delete.js:21: // Strong functions can't have
properties added to them, and will be tested as a
On 2015/05/22 11:34:50, rossberg wrote:
Instead of this, why not make the test below check with
Object.isExtensible, and
skip the respective bits if false?
It's kind of nasty because I interleave asserts that the property still
exists after each attempted delete. I didn't want to introduce a lot of
logic just for this one case. The actual special case test is just one
extra line.
https://codereview.chromium.org/1156573002/diff/40001/test/mjsunit/strong/object-delete.js#newcode35
test/mjsunit/strong/object-delete.js:35: return delete o["foo"];
On 2015/05/22 11:34:50, rossberg wrote:
Change this to an actual computation (e.g., Date()+""), otherwise it
won't be
distinguishable from the previous (same below).
Done. Added as another case (want to keep both of these in case we do
something crazy with [] later).
https://codereview.chromium.org/1156573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
