LGTM
Just a few style nits.
If Toon is around you should probably have him review this too since most
of the
changes are related to the runtime.
https://codereview.chromium.org/1156573002/diff/140001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1156573002/diff/140001/src/elements.cc#newcode940
src/elements.cc:940: if (obj->map()->is_strong() &&
!backing_store->is_the_hole(key)) {
When do we holes in the backing store of a strong object?
https://codereview.chromium.org/1156573002/diff/140001/test/mjsunit/strong/object-delete.js
File test/mjsunit/strong/object-delete.js (right):
https://codereview.chromium.org/1156573002/diff/140001/test/mjsunit/strong/object-delete.js#newcode53
test/mjsunit/strong/object-delete.js:53: with(o) {
with (
https://codereview.chromium.org/1156573002/diff/140001/test/mjsunit/strong/object-delete.js#newcode128
test/mjsunit/strong/object-delete.js:128: let deletePropertyFuncsSloppy
= [deleteFromObjectSloppy,
let deletePropertyFuncsSloppy = [
deleteFromObjectSloppy,
deleteFromObjectKeyedSloppy,
...
];
https://codereview.chromium.org/1156573002/diff/140001/test/mjsunit/strong/object-delete.js#newcode171
test/mjsunit/strong/object-delete.js:171: [{configurable:true,
value:"bar"},
{configurable: true, value: "bar"},
https://codereview.chromium.org/1156573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
