On 2015/05/27 18:09:33, conradw wrote:
https://codereview.chromium.org/1156573002/diff/60001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1156573002/diff/60001/src/elements.cc#newcode1405
src/elements.cc:1405: dictionary, entry, obj->map()->is_strong());
On 2015/05/22 14:01:26, rossberg wrote:
> Do we have to pass down the flag here? It seems that if the object is
strong,
> there is no point in even making the call, and you can immediately set
the
> result to false right here.
Yes, missed this.
https://codereview.chromium.org/1156573002/diff/60001/test/mjsunit/strong/object-delete.js
File test/mjsunit/strong/object-delete.js (right):
https://codereview.chromium.org/1156573002/diff/60001/test/mjsunit/strong/object-delete.js#newcode115
test/mjsunit/strong/object-delete.js:115: assertTrue(delete o);
On 2015/05/22 14:01:26, rossberg wrote:
> I'm confused, shouldn't this be a SyntaxError in strict mode?
Yes, mistake here. I can't actually run the strongObjects part of the
tests
just
now due to the Array/map caching problems. Will re-write tests when
rebasing
on
top of fix for that.
https://codereview.chromium.org/1156573002/diff/60001/test/mjsunit/strong/object-delete.js#newcode148
test/mjsunit/strong/object-delete.js:148: testStrongObjectDelete();
On 2015/05/22 14:01:26, rossberg wrote:
> It seems we don't have tests for redundant deletes succeeding.
Done, I thought they should fail (and should have tested for that anyway).
Caching problems have now been fixed.
https://codereview.chromium.org/1156573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
