LGTM.
http://codereview.chromium.org/521041/diff/3005/4018 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/521041/diff/3005/4018#newcode402 src/ia32/ic-ia32.cc:402: __ pop(eax); // return address Maybe add a comment explaining why popping the return address of the stack is a good idea in the common case. http://codereview.chromium.org/521041/diff/3005/4018#newcode419 src/ia32/ic-ia32.cc:419: __ bind(&index_ok); Maybe add a comment explaining why you need to duplicate the receiver and key on the stack. http://codereview.chromium.org/521041/diff/3005/4018#newcode421 src/ia32/ic-ia32.cc:421: __ push(Operand(esp, 1 * kPointerSize)); // key __ push(edx) ? http://codereview.chromium.org/521041
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
