http://codereview.chromium.org/521041/diff/3005/4018 File src/ia32/ic-ia32.cc (right):
http://codereview.chromium.org/521041/diff/3005/4018#newcode402 src/ia32/ic-ia32.cc:402: __ pop(eax); // return address On 2010/01/07 09:58:58, Kasper Lund wrote:
Maybe add a comment explaining why popping the return address of the
stack is a
good idea in the common case.
Done. I;m not sure if it make a big difference. But I guess performing the load early is better in the fast case. http://codereview.chromium.org/521041/diff/3005/4018#newcode419 src/ia32/ic-ia32.cc:419: __ bind(&index_ok); On 2010/01/07 09:58:58, Kasper Lund wrote:
Maybe add a comment explaining why you need to duplicate the receiver
and key on
the stack.
Done. http://codereview.chromium.org/521041/diff/3005/4018#newcode421 src/ia32/ic-ia32.cc:421: __ push(Operand(esp, 1 * kPointerSize)); // key On 2010/01/07 09:58:58, Kasper Lund wrote:
__ push(edx) ?
Done. http://codereview.chromium.org/521041
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
