LGTM.

http://codereview.chromium.org/521041/diff/3005/4018
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/521041/diff/3005/4018#newcode407
src/ia32/ic-ia32.cc:407: __ mov(ecx, FieldOperand(ebx,
HeapObject::kMapOffset));
The next three instructions are abstracted as
MacroAssembler::IsObjectStringType:

Condition is_string = masm->IsObjectStringType(ebx, ecx, ecx);
__ j(NegateCondition(is_string), &miss);

http://codereview.chromium.org/521041
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to