High-level question: why did you choose to make this throw on failure? It
could
just return false if the property already exists. That'd make your array
case
simpler, for one.
https://codereview.chromium.org/1154233003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/1154233003/diff/1/include/v8.h#newcode2595
include/v8.h:2595: V8_WARN_UNUSED_RESULT Maybe<bool>
CreateDataProperty(Local<Context> context,
Please add a comment explaining what this does, how it fails, what it
returns.
You could also reference the spec from the comment.
https://codereview.chromium.org/1154233003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
