Looking good. Some final comments.
https://codereview.chromium.org/1154233003/diff/80001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1154233003/diff/80001/src/api.cc#newcode3482
src/api.cc:3482:
isolate->factory()->NewStringFromStaticChars("length")))) {
isolate->factory()->length_string()
https://codereview.chromium.org/1154233003/diff/80001/src/api.cc#newcode3496
src/api.cc:3496: if (it.property_details().attributes() & DONT_DELETE)
return Just(false);
!it.IsConfigurable()
https://codereview.chromium.org/1154233003/diff/80001/src/api.cc#newcode3539
src/api.cc:3539: if (self->IsAccessCheckNeeded() &&
!isolate->MayAccess(self)) {
According to https://etherpad.mozilla.org/html5-cross-origin-objects
this should throw an exception. If so, you'll have to move this up to
the top of the function and check it first.
https://codereview.chromium.org/1154233003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
