https://codereview.chromium.org/1154233003/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1154233003/diff/1/src/api.cc#newcode3556
src/api.cc:3556: self, isolate->factory()->Uint32ToString(index),
value_obj, NONE,
On 2015/05/27 07:28:29, jochen wrote:
On 2015/05/26 at 19:40:55, Toon Verwaest wrote:
> You cannot use SetOwn... For elements at this moment. This will do
something
entirely random and broken. Add a test and you'll see...

this code path is covered by the test that sets arr[0] = 42 and arr[1]
= 23

it's also what DefineObjectProperty does...

I can guarantee you that that code path doesn't work. I wrote it.

https://codereview.chromium.org/1154233003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to