Hi Erik,
I think more scalable and cleaner approach would be to make the
concatenation
script to insert all these changes locally. That approach will continue to
work
for new test files in contrast to manual edits.
https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task.cc
File src/background-parsing-task.cc (right):
https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task.cc#newcode75
src/background-parsing-task.cc:75: } // namespace v8
Other files (e.g. src/allocation.cc) now have "} } // namespace
v8::internal"
Maybe do the same here? Or change the other files.
https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-graph-visualizer.cc
File test/cctest/compiler/test-graph-visualizer.cc (right):
https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-graph-visualizer.cc#newcode20
test/cctest/compiler/test-graph-visualizer.cc:20: namespace
test_graph_visualizer {
Now some tests are namespaced and others are not.
I think this should be done in concatenation script: insert "namespace
${test-file} {" before "using namespace v8::internal;".
https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-operator.cc
File test/cctest/compiler/test-operator.cc (right):
https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-operator.cc#newcode286
test/cctest/compiler/test-operator.cc:286: #undef FOLD
This should be done in concatenation script.
https://codereview.chromium.org/1163803002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
