On 2015/06/01 15:52:40, ulan wrote:
wow, lgtm.
After you removed the wrapping of tests and undefs, does this CL still
help
with
concatenation?
For now I will just not concatenate the affected files. It's quite hard to
automate namespace stuff. One unexpected thing I found was that this fails:
namespace a {
void foo();
}
namespace b {
void foo();
}
namespace {
using namespace a;
}
using namespace b;
foo(); // This is ambiguous because both 'using' declarations are still in
effect!
https://codereview.chromium.org/1163803002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
