https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task.cc
File src/background-parsing-task.cc (right):
https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task.cc#newcode75
src/background-parsing-task.cc:75: } // namespace v8
On 2015/06/01 13:08:24, ulan wrote:
Other files (e.g. src/allocation.cc) now have "} } // namespace
v8::internal"
Maybe do the same here? Or change the other files.
I've now done this. It's made the CL a bit unwieldy.
https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-graph-visualizer.cc
File test/cctest/compiler/test-graph-visualizer.cc (right):
https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-graph-visualizer.cc#newcode20
test/cctest/compiler/test-graph-visualizer.cc:20: namespace
test_graph_visualizer {
On 2015/06/01 13:08:24, ulan wrote:
Now some tests are namespaced and others are not.
I think this should be done in concatenation script: insert "namespace
${test-file} {" before "using namespace v8::internal;".
test namespaces removed
https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-operator.cc
File test/cctest/compiler/test-operator.cc (right):
https://codereview.chromium.org/1163803002/diff/1/test/cctest/compiler/test-operator.cc#newcode286
test/cctest/compiler/test-operator.cc:286: #undef FOLD
On 2015/06/01 13:08:24, ulan wrote:
This should be done in concatenation script.
Done
https://codereview.chromium.org/1163803002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
