LGTM so far.

http://codereview.chromium.org/541047/diff/1004/1007
File src/fast-codegen.cc (right):

http://codereview.chromium.org/541047/diff/1004/1007#newcode104
src/fast-codegen.cc:104: __ pop(result_register());
As already discussed the push/pop around TestAndBranch could be
optimized in case we don't have to call the ToBooleanStub in
TestAndBranch.

http://codereview.chromium.org/541047/diff/1004/1008
File test/mjsunit/compiler/short-circuit.js (right):

http://codereview.chromium.org/541047/diff/1004/1008#newcode1
test/mjsunit/compiler/short-circuit.js:1: // Copyright 2009 the V8
project authors. All rights reserved.
2010?

http://codereview.chromium.org/541047
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to