On Thu, Jan 14, 2010 at 1:25 PM, <[email protected]> wrote: > LGTM. > > > http://codereview.chromium.org/541047/diff/1004/1006 > File src/ia32/fast-codegen-ia32.cc (right): > > http://codereview.chromium.org/541047/diff/1004/1006#newcode1062 > src/ia32/fast-codegen-ia32.cc:1062: __ RecordWrite(ecx, offset, edx, > ebx); > Are we using result_register() instead of eax for flexibility? If so, > shouldn't we assert that ecx, edx, and ebx are not result_register()? > > Not for flexibility but for documentation. When I mean the register that kAccumulator goes into, I write result_register(). When I mean an explicit use of eax that could as well be some other register I just write eax.
There are obviously places where we assume they are the same, and I'm not too worried about that. I also don't think we need to worry about flexibility in changing it. It doesn't make sense for it to be anything other than the one that function return values are in.
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
