LGTM.
http://codereview.chromium.org/541047/diff/3005/2002 File src/fast-codegen.h (right): http://codereview.chromium.org/541047/diff/3005/2002#newcode232 src/fast-codegen.h:232: void DropAndApply(int count, Expression::Context context, Register reg); Extra space. http://codereview.chromium.org/541047/diff/3005/2003 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/541047/diff/3005/2003#newcode506 src/ia32/fast-codegen-ia32.cc:506: __ j(not_zero, if_true); &discard as well. http://codereview.chromium.org/541047/diff/3005/2006 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/541047/diff/3005/2006#newcode512 src/x64/fast-codegen-x64.cc:512: __ j(not_zero, if_true); branch to &discard as well here? http://codereview.chromium.org/541047/diff/3005/2006#newcode1043 src/x64/fast-codegen-x64.cc:1043: // Reciever is now under the key and value. Typo -> "receiver" http://codereview.chromium.org/541047
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
