https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode315
src/objects.cc:315: if (structure->IsAccessorInfo()) {
IsExecutableAccessorInfo()?
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode3194
src/objects.cc:3194: if (found) return result;
Missing break; ?
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode3365
src/objects.cc:3365: if (receiver->IsJSArray()) {
You dropped CheckArrayAbuse() calls. Was it done intentionally?
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode12811
src/objects.cc:12811: return;
nit: Do we need return; here?
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode12881
src/objects.cc:12881: Handle<JSArray>::cast(receiver)->length())) {
What about adding DCHECK(receiver->map()->is_observed()); or a comment
to ease understanding.
https://codereview.chromium.org/1172683003/diff/120001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1172683003/diff/120001/src/objects.h#newcode1892
src/objects.h:1892: static void
SetSloppyArgumentsElements(Handle<JSObject> object,
"SetSloppyArgumentsElement" to be consistent.
https://codereview.chromium.org/1172683003/diff/120001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1172683003/diff/120001/test/cctest/test-api.cc#newcode13269
test/cctest/test-api.cc:13269: global->ForceSet(access_property,
v8::Int32::New(isolate, 8));
I think it makes sense to add the above comment here.
https://codereview.chromium.org/1172683003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
