Addressed comments
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode315
src/objects.cc:315: if (structure->IsAccessorInfo()) {
On 2015/06/11 13:44:25, Igor Sheludko wrote:
IsExecutableAccessorInfo()?
It's in a weird state since it's the only subclass. IsAccessorInfo calls
IsExecutableAccessorInfo... We should get rid of that distinction later.
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode3194
src/objects.cc:3194: if (found) return result;
On 2015/06/11 13:44:25, Igor Sheludko wrote:
Missing break; ?
Done.
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode3365
src/objects.cc:3365: if (receiver->IsJSArray()) {
On 2015/06/11 13:44:25, Igor Sheludko wrote:
You dropped CheckArrayAbuse() calls. Was it done intentionally?
Done.
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode12811
src/objects.cc:12811: return;
On 2015/06/11 13:44:25, Igor Sheludko wrote:
nit: Do we need return; here?
Done.
https://codereview.chromium.org/1172683003/diff/120001/src/objects.cc#newcode12881
src/objects.cc:12881: Handle<JSArray>::cast(receiver)->length())) {
On 2015/06/11 13:44:25, Igor Sheludko wrote:
What about adding DCHECK(receiver->map()->is_observed()); or a comment
to ease
understanding.
Done.
https://codereview.chromium.org/1172683003/diff/120001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1172683003/diff/120001/test/cctest/test-api.cc#newcode13269
test/cctest/test-api.cc:13269: global->ForceSet(access_property,
v8::Int32::New(isolate, 8));
On 2015/06/11 13:44:25, Igor Sheludko wrote:
I think it makes sense to add the above comment here.
Done.
https://codereview.chromium.org/1172683003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
