lgtm with nits:
https://codereview.chromium.org/1172683003/diff/120001/src/elements.h
File src/elements.h (right):
https://codereview.chromium.org/1172683003/diff/120001/src/elements.h#newcode49
src/elements.h:49: }
Empty line is missing.
https://codereview.chromium.org/1172683003/diff/120001/src/elements.h#newcode195
src/elements.h:195: virtual Handle<Object> Set(Handle<JSObject> holder,
uint32_t key,
Please make it protected.
https://codereview.chromium.org/1172683003/diff/120001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1172683003/diff/120001/src/objects.h#newcode1650
src/objects.h:1650: enum SetPropertyMode {
It looks like this enum is not used anymore.
https://codereview.chromium.org/1172683003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
