Can you ensure that the following works as expected?
- [[Call]]ing %TypedArray% should always fail.
- [[Construct]]ing should fail if the right internal slots are not present.
It
should work otherwise. You probably need to use Reflect.construct to test
this
I do not think the [[Construct]] behavior works and it seems complicated to
get
that right too.
What is %TypedArray%.name? I think it should not have a name property at
all but
it is not clear to me.
https://codereview.chromium.org/1186733002/diff/40001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1186733002/diff/40001/src/typedarray.js#newcode59
src/typedarray.js:59: throw MakeTypeError(kIncompatibleMethodReceiver,
"TypedArray.byteLength", this);
long line
https://codereview.chromium.org/1186733002/diff/40001/src/typedarray.js#newcode327
src/typedarray.js:327: TypedArray_GetByteOffset, DONT_ENUM |
DONT_DELETE);
why DONT_DELETE?
https://codereview.chromium.org/1186733002/diff/40001/src/typedarray.js#newcode329
src/typedarray.js:329: TypedArray_GetByteLength, DONT_ENUM |
DONT_DELETE);
same here and other places. We should also have tests that these
accessors have the right flags.
https://codereview.chromium.org/1186733002/diff/40001/src/typedarray.js#newcode333
src/typedarray.js:333: TypedArrayGetToStringTag);
DONT_ENUM?
https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/es6/built-in-accessor-names.js
File test/mjsunit/es6/built-in-accessor-names.js (right):
https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/es6/built-in-accessor-names.js#newcode9
test/mjsunit/es6/built-in-accessor-names.js:9: function
GetPropertyDescriptor(object, field, expectedDepth) {
getP...
https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/es6/built-in-accessor-names.js#newcode47
test/mjsunit/es6/built-in-accessor-names.js:47: assertGetterName('get
buffer', f.prototype, 'buffer', 1);
I would probably just change this to `f.prototype.__proto__` or remove
the loop and just test Uint8Array.prototype.__proto__. There are already
other tests covering that these all have the correct prototype chain.
https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/regress/regress-typedarray-length.js
File test/mjsunit/regress/regress-typedarray-length.js (right):
https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/regress/regress-typedarray-length.js#newcode74
test/mjsunit/regress/regress-typedarray-length.js:74: // Ensure we
cannot delete length, byteOffset, byteLength.
I think this is invalid. Maybe justs file a bug and we can get back to
this.
https://codereview.chromium.org/1186733002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
