LGTM
https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/es6/built-in-accessor-names.js
File test/mjsunit/es6/built-in-accessor-names.js (right):
https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/es6/built-in-accessor-names.js#newcode47
test/mjsunit/es6/built-in-accessor-names.js:47: assertGetterName('get
buffer', f.prototype, 'buffer', 1);
On 2015/06/15 23:28:34, littledan wrote:
On 2015/06/15 16:23:12, arv wrote:
> I would probably just change this to `f.prototype.__proto__` or
remove the
loop
> and just test Uint8Array.prototype.__proto__. There are already
other tests
> covering that these all have the correct prototype chain.
Where are those tests?
I assume you have added tests that asserts that f.prototype.__proto__
=== %TypedArray%.prototype somewhere?
https://codereview.chromium.org/1186733002/diff/80001/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1186733002/diff/80001/src/harmony-typedarray.js#newcode51
src/harmony-typedarray.js:51: var TypedArrayPrototype =
GlobalUint8Array.prototype.__proto__;
This is the same as TypedArray.prototype which reads better:
var TypedArrayPrototype = TypedArray.prototype;
https://codereview.chromium.org/1186733002/diff/80001/test/mjsunit/regress/regress-typedarray-length.js
File test/mjsunit/regress/regress-typedarray-length.js (right):
https://codereview.chromium.org/1186733002/diff/80001/test/mjsunit/regress/regress-typedarray-length.js#newcode107
test/mjsunit/regress/regress-typedarray-length.js:107:
assertTrue(Int32Array.prototype.__proto__.hasOwnProperty("length"));
Maybe add tests that check the descriptor instead?
https://codereview.chromium.org/1186733002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
