https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/es6/built-in-accessor-names.js
File test/mjsunit/es6/built-in-accessor-names.js (right):
https://codereview.chromium.org/1186733002/diff/40001/test/mjsunit/es6/built-in-accessor-names.js#newcode47
test/mjsunit/es6/built-in-accessor-names.js:47: assertGetterName('get
buffer', f.prototype, 'buffer', 1);
On 2015/06/16 22:38:22, littledan wrote:
On 2015/06/16 16:24:49, arv wrote:
> On 2015/06/15 23:28:34, littledan wrote:
> > On 2015/06/15 16:23:12, arv wrote:
> > > I would probably just change this to `f.prototype.__proto__` or
remove the
> > loop
> > > and just test Uint8Array.prototype.__proto__. There are already
other
tests
> > > covering that these all have the correct prototype chain.
> >
> > Where are those tests?
>
> I assume you have added tests that asserts that
f.prototype.__proto__ ===
> %TypedArray%.prototype somewhere?
I'm not sure how I could add that test, as there's no direct way to
get at
%TypedArray%.prototype besides through f.prototype.__proto__.
The way to do it is something like this:
var TypedArray = Uint8Array.__proto__;
var TypedArrayPrototype = TypedArray.prototype;
for (let f of typedArrays) {
assertEquals(TypedArray, f.__proto__);
assertEquals(TypedArrayPrototype, f.prototype.__proto__);
}
And then test the names by themselves.
assertGetterName('get byteOffset', TypedArrayPrototype, 'byteOffset')
https://codereview.chromium.org/1186733002/diff/80001/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1186733002/diff/80001/src/harmony-typedarray.js#newcode51
src/harmony-typedarray.js:51: var TypedArrayPrototype =
GlobalUint8Array.prototype.__proto__;
On 2015/06/16 22:38:23, littledan wrote:
On 2015/06/16 16:24:49, arv wrote:
> This is the same as TypedArray.prototype which reads better:
>
> var TypedArrayPrototype = TypedArray.prototype;
TypedArray is not exposed.
You defined it on line 50.
https://codereview.chromium.org/1186733002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
