LGTM with nits + more test coverage
https://codereview.chromium.org/1205023002/diff/40001/src/compiler/arm/instruction-codes-arm.h
File src/compiler/arm/instruction-codes-arm.h (right):
https://codereview.chromium.org/1205023002/diff/40001/src/compiler/arm/instruction-codes-arm.h#newcode96
src/compiler/arm/instruction-codes-arm.h:96: V(ArmPoke)
\
I'm not totally happy with the "Poke" suffix, because this term in
itself is usually not semantically connected to stack manipulation.
"WriteStackEntry"? "StoreStackArgument"? Hmmm...
https://codereview.chromium.org/1205023002/diff/40001/test/cctest/compiler/test-run-machops.cc
File test/cctest/compiler/test-run-machops.cc (right):
https://codereview.chromium.org/1205023002/diff/40001/test/cctest/compiler/test-run-machops.cc#newcode5195
test/cctest/compiler/test-run-machops.cc:5195:
What about float/double/int64_t/... arguments/return values? If those
types are not supported yet (not clear to me), there should at least be
a comment about this.
Furthermore, please add tests with tons of arguments (probably with
mixed types), otherwise test coverage is a bit :-P * * * for most
calling conventions (0 - 2 args are probably in registers only).
https://codereview.chromium.org/1205023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
