https://codereview.chromium.org/1205023002/diff/40001/src/compiler/arm/instruction-codes-arm.h
File src/compiler/arm/instruction-codes-arm.h (right):
https://codereview.chromium.org/1205023002/diff/40001/src/compiler/arm/instruction-codes-arm.h#newcode96
src/compiler/arm/instruction-codes-arm.h:96: V(ArmPoke)
\
We can fix that naming later. Poke is in line with the ARM64 naming.
https://codereview.chromium.org/1205023002/diff/40001/test/cctest/compiler/test-run-machops.cc
File test/cctest/compiler/test-run-machops.cc (right):
https://codereview.chromium.org/1205023002/diff/40001/test/cctest/compiler/test-run-machops.cc#newcode5195
test/cctest/compiler/test-run-machops.cc:5195:
On 2015/06/25 07:15:59, Sven Panne wrote:
What about float/double/int64_t/... arguments/return values? If those
types are
not supported yet (not clear to me), there should at least be a
comment about
this.
Furthermore, please add tests with tons of arguments (probably with
mixed
types), otherwise test coverage is a bit :-P * * * for most calling
conventions
(0 - 2 args are probably in registers only).
Acknowledged.
https://codereview.chromium.org/1205023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
