https://codereview.chromium.org/1205023002/diff/80001/test/cctest/compiler/test-run-machops.cc
File test/cctest/compiler/test-run-machops.cc (right):
https://codereview.chromium.org/1205023002/diff/80001/test/cctest/compiler/test-run-machops.cc#newcode5160
test/cctest/compiler/test-run-machops.cc:5160: return a + b + c + d + e
+ f + g + h;
Using a non-commutative and non-associative operation would be more
helpful here: Permuted arguments can't be detected with "+".
https://codereview.chromium.org/1205023002/diff/80001/test/cctest/compiler/test-run-machops.cc#newcode5210
test/cctest/compiler/test-run-machops.cc:5210: kMachInt32, function,
param, param, param, param,
Using the same actual parameter for all formal parameters might disguise
bugs, e.g. accidentally duplicating/leaving out/permuting args.
https://codereview.chromium.org/1205023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
