Comment #5 on issue 4269 by [email protected]: Debug break points
should not be implemented by patching ICs
https://code.google.com/p/v8/issues/detail?id=4269#c5
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/c1b5d1743903c12880cbba3afaac9da1781d0a9f
commit c1b5d1743903c12880cbba3afaac9da1781d0a9f
Author: yangguo <[email protected]>
Date: Tue Jul 07 13:56:17 2015
Debugger: clear ICs on activating step-in to correctly flood accessor pairs.
If we compile handlers to call accessors, Debug::HandleStepIn won't get
called. Therefore we need to clear ICs each time. This has not been
necessary before because we used to patch ICs for breaking, and restored
them with cleared ICs. This is no longer the case. We do not use ICs
for breaking anymore, so they are not implicitly cleared any longer.
[email protected]
BUG=v8:4269
LOG=N
Review URL: https://codereview.chromium.org/1212253009
Cr-Commit-Position: refs/heads/master@{#29518}
[modify]
http://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f/src/debug.cc
[modify]
http://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f/src/debug.h
[modify]
http://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f/src/objects.cc
[modify]
http://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f/src/runtime/runtime-classes.cc
[modify]
http://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f/src/runtime/runtime-debug.cc
[modify]
http://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f/src/runtime/runtime-object.cc
[add]
http://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f/test/mjsunit/debug-stepin-accessor-ic.js
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
