Comment #6 on issue 4269 by [email protected]: Debug break points should not be implemented by patching ICs
https://code.google.com/p/v8/issues/detail?id=4269#c6
The following revision refers to this bug:https://chromium.googlesource.com/v8/v8.git/+/8965b683ce39bc3c24ed2466d189323d81a70852
commit 8965b683ce39bc3c24ed2466d189323d81a70852 Author: yangguo <[email protected]> Date: Fri Jul 10 08:49:14 2015 Debugger: use debug break slot to break on call. Break point at calls are currently set via IC. To change this, we need to set debug break slots instead. We also need to distinguish those debug break slots as calls to support step-in. To implement this, we add a data field to debug break reloc info to indicate non-call debug breaks or in case of call debug breaks, the number of arguments. We can later use this to find the callee on the evaluation stack in Debug::PrepareStep. BUG=v8:4269 [email protected] LOG=N Review URL: https://codereview.chromium.org/1222093007 Cr-Commit-Position: refs/heads/master@{#29561}[modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/arm/assembler-arm.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/arm/debug-arm.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/arm/full-codegen-arm.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/arm64/assembler-arm64.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/arm64/debug-arm64.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/arm64/full-codegen-arm64.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/assembler.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/assembler.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/builtins.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/builtins.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/code-stubs.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/debug.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/debug.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/disassembler.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/full-codegen.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/full-codegen.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/ia32/assembler-ia32.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/ia32/debug-ia32.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/ia32/full-codegen-ia32.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/mips/assembler-mips.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/mips/debug-mips.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/mips/full-codegen-mips.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/mips64/assembler-mips64.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/mips64/debug-mips64.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/mips64/full-codegen-mips64.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/x64/assembler-x64.h [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/x64/debug-x64.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/src/x64/full-codegen-x64.cc [modify] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/test/cctest/test-debug.cc [add] http://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852/test/mjsunit/debug-stepin-construct-call.js
--You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
