Comment #8 on issue 4269 by [email protected]: Debug break points should not be implemented by patching ICs
https://code.google.com/p/v8/issues/detail?id=4269#c8
The following revision refers to this bug:https://chromium.googlesource.com/v8/v8.git/+/fc9c5275c3a747caca709b7d5745579f70e61301
commit fc9c5275c3a747caca709b7d5745579f70e61301 Author: yangguo <[email protected]> Date: Wed Jul 15 09:22:33 2015 Debugger: use debug break slots to break at function exit. By not having to patch the return sequence (we patch the debug break slot right before it), we don't overwrite it and therefore don't have to keep the original copy of the code around. [email protected] BUG=v8:4269 LOG=N Review URL: https://codereview.chromium.org/1234833003 Cr-Commit-Position: refs/heads/master@{#29672}[modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm/assembler-arm-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm/assembler-arm.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm/debug-arm.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm/full-codegen-arm.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm/macro-assembler-arm.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm64/assembler-arm64-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm64/assembler-arm64.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm64/assembler-arm64.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm64/debug-arm64.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/arm64/full-codegen-arm64.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/assembler.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/assembler.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/builtins.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/debug.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/debug.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/factory.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/full-codegen.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/heap/mark-compact.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/heap/mark-compact.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/heap/objects-visiting-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ia32/assembler-ia32-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ia32/assembler-ia32.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ia32/assembler-ia32.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ia32/debug-ia32.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ia32/full-codegen-ia32.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ia32/macro-assembler-ia32.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ic/ic-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ic/ic.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/ic/ic.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/liveedit.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips/assembler-mips-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips/assembler-mips.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips/assembler-mips.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips/debug-mips.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips/full-codegen-mips.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips/macro-assembler-mips.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips64/assembler-mips64-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips64/assembler-mips64.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips64/assembler-mips64.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips64/debug-mips64.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips64/full-codegen-mips64.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/mips64/macro-assembler-mips64.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/objects-debug.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/objects-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/objects-printer.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/objects.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/objects.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/runtime/runtime-debug.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/x64/assembler-x64-inl.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/x64/assembler-x64.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/x64/debug-x64.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/x64/full-codegen-x64.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/src/x64/macro-assembler-x64.h [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/test/cctest/test-debug.cc [modify] http://crrev.com/fc9c5275c3a747caca709b7d5745579f70e61301/test/mjsunit/debug-return-value.js
--You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
