https://codereview.chromium.org/1219943002/diff/120001/test/mjsunit/harmony/simd.js
File test/mjsunit/harmony/simd.js (right):
https://codereview.chromium.org/1219943002/diff/120001/test/mjsunit/harmony/simd.js#newcode201
test/mjsunit/harmony/simd.js:201: assertTrue(SIMD.float32x4(1, 2, 3, 4)
== SIMD.float32x4(1, 2, 3, 4));
Unlike the other tests, this seems to be specific to float32x4. A way
out could be to use SIMD[type].splat(1) and SIMD[type].splat(NaN) (maybe
with replaceLane so you can have just one element different, if you
care) so you don't have to worry about the number of arguments.
https://codereview.chromium.org/1219943002/diff/120001/test/mjsunit/harmony/simd.js#newcode261
test/mjsunit/harmony/simd.js:261: return
Number.parseInt(typeName[typeName.length - 1]);
This won't work for int8x16. Maybe you could use SIMD[typeName].length
(#arguments that the function takes), or a regexp.
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
