Looking almost good. Sorry I overlooked the missing SameValue[Zero]
adaptation
earlier.
https://codereview.chromium.org/1219943002/diff/210001/test/mjsunit/harmony/reflect-apply.js
File test/mjsunit/harmony/reflect-apply.js (right):
https://codereview.chromium.org/1219943002/diff/210001/test/mjsunit/harmony/reflect-apply.js#newcode5
test/mjsunit/harmony/reflect-apply.js:5: // Flags: --harmony-reflect
--harmony-simd
This must not be needed, see other comment.
https://codereview.chromium.org/1219943002/diff/210001/test/mjsunit/object-toprimitive.js
File test/mjsunit/object-toprimitive.js (right):
https://codereview.chromium.org/1219943002/diff/210001/test/mjsunit/object-toprimitive.js#newcode28
test/mjsunit/object-toprimitive.js:28: // Flags: --harmony-simd
If this test does not use SIMDs then this flag should not be needed. If
the test nevertheless fails without setting the flag, then that's a
(serious) bug. You are probably missing places where you need to make
code paths dependent on the flag.
https://codereview.chromium.org/1219943002/diff/250001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1219943002/diff/250001/src/runtime.js#newcode953
src/runtime.js:953: function SameValue(x, y) {
This also needs to be extended, see the SIMD spec. Affects Object.is on
SIMD values.
https://codereview.chromium.org/1219943002/diff/250001/src/runtime.js#newcode967
src/runtime.js:967: function SameValueZero(x, y) {
Likewise. Affects maps/sets over SIMD values as keys.
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
