https://codereview.chromium.org/1219943002/diff/1/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/1219943002/diff/1/src/code-stubs.h#newcode2753
src/code-stubs.h:2753: SIMD_TYPE,
On 2015/07/06 23:59:04, bbudge wrote:
On 2015/07/02 13:35:43, rossberg wrote:
> Nit: simply SIMD would seem more consistent with the other names.
How about SIMD_VALUE, since SIMD is more of an adjective than a noun?
Fine with me.
https://codereview.chromium.org/1219943002/diff/1/src/contexts.h
File src/contexts.h (right):
https://codereview.chromium.org/1219943002/diff/1/src/contexts.h#newcode84
src/contexts.h:84: V(SIMD_OBJECT_INDEX, JSObject, simd_object)
\
On 2015/07/06 23:59:04, bbudge wrote:
On 2015/07/02 13:35:43, rossberg wrote:
> Is this actually used?
Turns out it's needed for bootstrapper.cc:1329:
native_context()->set_simd_object(*simd_object);
Well, that is just initialising the field. If it's never actually read,
that's likewise redundant.
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
