https://codereview.chromium.org/1208933006/diff/140001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1208933006/diff/140001/src/flag-definitions.h#newcode197
src/flag-definitions.h:197: V(harmony_futex, "harmony futex")
\
On 2015/07/08 at 17:54:20, Michael Starzinger wrote:
This flag seems to be only used in RUNTIME_ASSERTs, otherwise the
implementation seems to hinge off of harmony_atomics instead. Is this
intended? Is this flag needed?
Removed.
https://codereview.chromium.org/1208933006/diff/140001/src/harmony-atomics.js
File src/harmony-atomics.js (right):
https://codereview.chromium.org/1208933006/diff/140001/src/harmony-atomics.js#newcode149
src/harmony-atomics.js:149: return %_AtomicsFutexWait(ia, index, value,
timeout);
On 2015/07/08 at 17:54:20, Michael Starzinger wrote:
The %_FooBar syntax is used to indicate that at least one compiler
inlines this as an intrinsic. Since there are only runtime function
backing this so far, I would for using plain %FooBar instead, to not
confuse people about the expected overhead. Likewise below.
Done.
https://codereview.chromium.org/1208933006/diff/140001/src/runtime/runtime.h
File src/runtime/runtime.h (right):
https://codereview.chromium.org/1208933006/diff/140001/src/runtime/runtime.h#newcode67
src/runtime/runtime.h:67: F(AtomicsFutexWait, 4, 1) \
On 2015/07/08 at 17:54:20, Michael Starzinger wrote:
Please add a new FOR_EACH_INTRINSIC_FUTEX macro, each .cc file has
it's own macro.
Done.
https://codereview.chromium.org/1208933006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
