lgtm. (but we should revisit the busy wait at some point.)
https://codereview.chromium.org/1208933006/diff/240001/src/futex-emulation.cc
File src/futex-emulation.cc (right):
https://codereview.chromium.org/1208933006/diff/240001/src/futex-emulation.cc#newcode63
src/futex-emulation.cc:63: // TODO(binji): How long should this be?
Should it be configurable?
No idea. Ideally, we should have some notification from the interrupt
mechanism so that you do not have to busy-wait here. Perhaps you could
add a TODO here that reminds us to fix the busy wait?
https://codereview.chromium.org/1208933006/diff/240001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1208933006/diff/240001/test/cctest/test-api.cc#newcode21866
test/cctest/test-api.cc:21866: };
Thanks for the test, you are my hero!
https://codereview.chromium.org/1208933006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
