First batch of comments.
https://codereview.chromium.org/1208933006/diff/160001/src/futex-emulation.cc
File src/futex-emulation.cc (right):
https://codereview.chromium.org/1208933006/diff/160001/src/futex-emulation.cc#newcode18
src/futex-emulation.cc:18: FutexWaitList FutexEmulation::wait_list_;
Static initializers are not allowed by Chrome. You should use the
LazyInstance template.
https://codereview.chromium.org/1208933006/diff/160001/src/futex-emulation.cc#newcode39
src/futex-emulation.cc:39: if (node->prev_)
braces, please.
https://codereview.chromium.org/1208933006/diff/160001/src/futex-emulation.h
File src/futex-emulation.h (right):
https://codereview.chromium.org/1208933006/diff/160001/src/futex-emulation.h#newcode38
src/futex-emulation.h:38: : prev_(NULL),
NULL -> nullptr in new code, please.
https://codereview.chromium.org/1208933006/diff/160001/src/harmony-atomics.js
File src/harmony-atomics.js (right):
https://codereview.chromium.org/1208933006/diff/160001/src/harmony-atomics.js#newcode136
src/harmony-atomics.js:136: if (index < 0 || index >= ia.length) {
I believe you should not rely on the length property here because it
could be monkey-patched. You should use %_TypedArrayGetLength(ia) here.
Could you add tests with monkey-patched length and byteLength properties
for all the atomic ops?
https://codereview.chromium.org/1208933006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
