I like this!
https://codereview.chromium.org/1235153006/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1235153006/diff/20001/src/parser.cc#newcode4339
src/parser.cc:4339: proxy, VAR, scope_, RelocInfo::kNoPosition);
Shouldn't this be LET?
https://codereview.chromium.org/1235153006/diff/20001/src/parser.cc#newcode4344
src/parser.cc:4344: // TODO(@caitp): use an array literal to avoid
escape
Can you do that in this CL? It would avoid adding another runtime
function.
https://codereview.chromium.org/1235153006/diff/20001/test/mjsunit/regress/regress-508074.js
File test/mjsunit/regress/regress-508074.js (right):
https://codereview.chromium.org/1235153006/diff/20001/test/mjsunit/regress/regress-508074.js#newcode5
test/mjsunit/regress/regress-508074.js:5: // Flags:
--harmony-rest-parameters --harmony-arrow-functions
--allow-natives-syntax
Nit: line length
https://codereview.chromium.org/1235153006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
