On 2015/07/16 17:29:58, caitp wrote:
I've rebased on top of the order switch --- it's passing release tests,
but
fails a DCHECK(temps_.is_empty()) in Scope::FinalizeBlockScope().
Does this DCHECK really matter? Should temporaries always be declared in
the
top-level function scope?
Introduced a `TempScope()` method to find a scope which is safe for
temporary-declaration. if that's an approach people are alright with, can be
moved into a separate CL.
There's some missing test coverage which would fail (at least in debug
builds),
but be fixed by that change, like spread calls + destructuring or rest
parameters.
Or maybe the DCHECK in NewTemporary could just be removed --- is there any
reason why FinalizeBlockScope() needs to have an empty list of temporaries?
https://codereview.chromium.org/1235153006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
