lgtm
https://codereview.chromium.org/1235153006/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1235153006/diff/20001/src/parser.cc#newcode4339
src/parser.cc:4339: proxy, VAR, scope_, RelocInfo::kNoPosition);
On 2015/07/15 13:53:35, caitp wrote:
On 2015/07/15 12:10:16, rossberg wrote:
> Shouldn't this be LET?
There are 2 things that get in the way: missing position information,
and the
var is already declared as VAR. can work around it but maybe better
for a
followup?
I'm fine with that. You can find a related TODO in the tests of the
parameter scoping CL that I uploaded earlier today. :)
https://codereview.chromium.org/1235153006/diff/20001/src/parser.cc#newcode4344
src/parser.cc:4344: // TODO(@caitp): use an array literal to avoid
escape
On 2015/07/15 13:53:35, caitp wrote:
On 2015/07/15 12:10:16, rossberg wrote:
> Can you do that in this CL? It would avoid adding another runtime
function.
This is proving to be very difficult to accomplish, especially for
arrow
functions. I think it will take some time to juggle the literal
indexes just
right
I see. Fine to leave for follow-up as well.
https://codereview.chromium.org/1235153006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
