http://codereview.chromium.org/555164/diff/1/7 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/555164/diff/1/7#newcode6201 src/arm/codegen-arm.cc:6201: int CEntryStub::MinorKey() { On 2010/02/01 08:57:19, Søren Gjesse wrote:
Don't you also need a new minor key here?
See comment for src/x64/codegen-x64.cc
Done. http://codereview.chromium.org/555164/diff/1/4 File src/codegen.h (right): http://codereview.chromium.org/555164/diff/1/4#newcode334 src/codegen.h:334: ExitFrame::Mode mode = ExitFrame::MODE_NORMAL) On 2010/02/01 08:57:19, Søren Gjesse wrote:
Indention.
Done. http://codereview.chromium.org/555164/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/555164/diff/1/2#newcode9078 src/ia32/codegen-ia32.cc:9078: int CEntryStub::MinorKey() { On 2010/02/01 08:57:19, Søren Gjesse wrote:
See comment for src/x64/codegen-x64.cc.
Done. http://codereview.chromium.org/555164/diff/1/6 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/555164/diff/1/6#newcode7337 src/x64/codegen-x64.cc:7337: int CEntryStub::MinorKey() { On 2010/02/01 08:57:19, Søren Gjesse wrote:
Please change this to use two 1-bit bitfields as e.g.
CallFunctionStub. if
_WIN64 is not defined just encode 0 is the ResultSize bitfield.
You can then move CEntryStub::MinorKey() to codegen.h (codegen.cc) and
have it
shared between platforms.
Done. http://codereview.chromium.org/555164 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
