[v8-dev] Re: Fix exit frame type in breakpoint stub (issue555164)

Tue, 02 Feb 2010 22:18:39 -0800

There is an error in the win32 build, due to the commented lines in codegen.cc. 

http://codereview.chromium.org/555164/diff/11001/12011
File src/codegen.cc (right):

http://codereview.chromium.org/555164/diff/11001/12011#newcode485
src/codegen.cc:485: const indirect_result = result_size_ > 1;
This seems really wrong.  Either make the type (int) explicit, or make
this a constant bool.

http://codereview.chromium.org/555164/diff/11001/12011#newcode491
src/codegen.cc:491: | IndirectResultBits::encode(indirect_result > 1);
Shouldn't this just be indirect_result, not indirect_result > 1?  The
second expression is never true.

In all cases except _WIN64, this is encoding 0, which probably doesn't
affect the bitwise or, so maybe the entire return statement should be in
an #ifdef, and be optimized in all cases except WIN64 to just return
ExitFrameModeBits::encode(mode).

http://codereview.chromium.org/555164

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev






















					Reply via email to