LGTM
http://codereview.chromium.org/555164/diff/36/1022 File src/codegen.cc (right): http://codereview.chromium.org/555164/diff/36/1022#newcode482 src/codegen.cc:482: ASSERT(result_size_ <= 2); I suggest you collect the comments on how values are returned from C++ on the different platforms (normally one return value but in rare cases two) either here or some other place in codegen*. http://codereview.chromium.org/555164/diff/36/1014 File src/codegen.h (right): http://codereview.chromium.org/555164/diff/36/1014#newcode356 src/codegen.h:356: // if complex results must be written to address passed as first argument I find this comment a bit obscure. Also it should be with uppercase initial letter and end with a period. http://codereview.chromium.org/555164 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
